Best practice forum (Archived)

Minor bug: "Appraisal Status" column in Appraisal Status report source

 
Maurice Moore
Minor bug: "Appraisal Status" column in Appraisal Status report source
by Maurice Moore - Tuesday, 3 June 2014, 9:17 PM
 

I added the column "Appraisal Status" to a custom version of the Appraisal Status report but the value returned is numeric (1,2 3 etc) rather than 'the' status expressed in human readable form. Was that the intent?

Totara 2.5.13

me
Re: Minor bug: "Appraisal Status" column in Appraisal Status report source
by George Angus - Thursday, 5 June 2014, 10:01 PM
Group Totara

Hi Maurice,

At the top of /totara/appraisal/lib.php there are constants defined

46 /*
47 Appraisal status
48 */
49 const STATUS_DRAFT = 0;
50 const STATUS_ACTIVE = 1;
51 const STATUS_CLOSED = 2;
52 const STATUS_COMPLETED = 3;

If you add a 4th constant here it should be fine. 

regards,

George.

Nathan Lewis
Re: Minor bug: "Appraisal Status" column in Appraisal Status report source
by Nathan Lewis - Sunday, 8 June 2014, 2:40 PM
Group Totara

Hi Maurice.

There was a bit of confusion about what you were reporting, so George's answer doesn't apply.

I checked it out and the column does indeed show a code, while it really should show a human-readable string. I'll put in a bug report to get someone to change it. The codes listed in George's report indicate what the numbers mean, which might be useful to you until the patch arrives (which will hopefully be soon).

Nathan

Ciaran Irvine (Core Developer)
Re: Minor bug: "Appraisal Status" column in Appraisal Status report source
by Ciaran Irvine (Core Developer) - Monday, 9 June 2014, 9:25 PM
 

A fix for this issue was included in today's (10th June 2014) release of Totara 2.5.14

Ciaran Irvine (Core Developer)
Re: Minor bug: "Appraisal Status" column in Appraisal Status report source
by Ciaran Irvine (Core Developer) - Monday, 16 June 2014, 10:36 PM
 

A fix for this issue was included in today's (17th June 2014) release of Totara 2.6.3