Hi Alan,

I've gone through all the changes in the base customtotara from 2.4 to 2.5. You are right, there are some code changes. You will probably need to be change all these as well in your 2.5 theme - replace customtotara with the directory your theme is in in all the lines below:

/theme/customtotara/config.php change the last line

$THEME->csspostprocess = 'customtotara_process_css';

to

$THEME->csspostprocess = 'theme_customtotara_process_css';

theme/customtotara/lib.php, Rename

function customtotara_process_css($css, $theme) {

to

function theme_customtotara_process_css($css, $theme) {

And in that function on the second-last line change

$css = customtotara_set_customcss($css, $customcss); 

to

$css = theme_customtotara_set_customcss($css, $customcss);

Still in lib.php, Rename

function customtotara_set_customcss($css, $customcss) {

to

function theme_customtotara_set_customcss($css, $customcss) {

Immediately after function theme_customtotara_set_customcss add a new function:

/**
 * Serves any files associated with the theme settings.
 *
 * @param stdClass $course
 * @param stdClass $cm
 * @param context $context
 * @param string $filearea
 * @param array $args
 * @param bool $forcedownload
 * @param array $options
 * @return bool
 */
function theme_customtotara_pluginfile($course, $cm, $context, $filearea, $args, $forcedownload, array $options = array()) {
    if ($context->contextlevel == CONTEXT_SYSTEM && ($filearea === 'logo' || $filearea === 'favicon')) {
        $theme = theme_config::load('customtotara');
        return $theme->setting_file_serve($filearea, $args, $forcedownload, $options);
    } else {
        send_file_not_found();
    }

And lastly, in settings.php where you changed "new admin_setting_configfilepicker" to "new admin_setting_configstoredfile" in my first reply, you should add the line

$setting->set_updatedcallback('theme_reset_all_caches');

This line should also be added after all the $setting = new admin_setting_* lines in that file - 7 of them in the base standardtotara.

If all that works then I'll put together instructions for all the clients who may have 2.4 custom themes as I can see this being a problem for quite a few clients.